[PATCH] D74691: [Attributor] add some pattern to containsCycle

[omar ahmed via Phabricator via llvm-commits]

omarahmed added a comment.

> Caps on the name. Be sure to check the nearby code and use clang-format (it seems you have done so, just reminding).

I thought the default clang-format do it as required , I realized now that it is different :) , will fix it



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2371
 // TODO: Replace with more efficent code
 static bool containsCycle(Function &F) {
+  bool noAnalysis = false;
----------------
baziotis wrote:
> I think you still need to pass `A`. Are you sure this compiles?
ohhh sry tried something and forgot to make it back in this part :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691