[PATCH] D74770: [test-suite] Work around undefined behaviour in ldecod
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 19 05:13:53 PST 2020
kristof.beyls accepted this revision.
kristof.beyls added a comment.
This revision is now accepted and ready to land.
After chatting with Oliver, he states that he did run ubsan before and after this change, and the undefined behaviour that was causing the segfaults is gone with this change.
(There are apparently other undefined behaviours flagged by ubsan, but they are unrelated).
I also don't know much about H264 <https://reviews.llvm.org/H264> decoding, but the removal of undefined behaviour as indicated by ubsan together with no change in output makes me believe this change is good enough for how the test-suite is used.
LGTM.
Repository:
rT test-suite
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74770/new/
https://reviews.llvm.org/D74770
More information about the llvm-commits
mailing list