[PATCH] D74756: [yaml2obj] - Change the order of implicitly created sections.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 19 03:40:18 PST 2020
grimar added inline comments.
================
Comment at: llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml:58
+# CASE2: Info:
+# CASE2-SAME: 1
+# CASE2: Name: .dynstr
----------------
jhenderson wrote:
> MaskRay wrote:
> > Indent, i.e. `CASE2-SAME: 1`
> I know I suggested this behaviour previously, but I realise that there is a slight flaw in it, as it will also match "Info: 1234" or "Info: 2211" for example. I think you need ^$ regex markers too.
I am not sure how to use `{{^}}` with `-SAME`
The following does not work (and I think it is correct that it is not):
```
# CASE1: Info:
# CASE1-SAME: {{^}}2{{$}}
```
I think we can use `-NOT`, I did it here. Looks fine?
(I've only applied this approach here as it is the only test I added in this diff, we can update other places independently).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74756/new/
https://reviews.llvm.org/D74756
More information about the llvm-commits
mailing list