[PATCH] D74822: [AArch64][ASMParser] Refuse equal source/destination for LDRAA/LDRAB

Oliver Stannard (Linaro) via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 03:38:15 PST 2020


ostannard added a comment.

The exact line in the architecture manual is `if wback && n == t && n != 31 then`. I _think_ we already get the `n != 31` case correct, because we will parse one operand to XZR and the other to SP, but could you please add a test for this?



================
Comment at: llvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp:4123
+      return Error(Loc[0],
+          "unpredictable LDRA instruction, writeback base is also a source");
+    break;
----------------
s/source/destination/ ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74822/new/

https://reviews.llvm.org/D74822





More information about the llvm-commits mailing list