[PATCH] D74756: [yaml2obj] - Change the order of implicitly created sections.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 02:32:48 PST 2020


jhenderson added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/implicit-sections-info.yaml:58
+# CASE2:      Info:
+# CASE2-SAME: 1
+# CASE2:      Name: .dynstr
----------------
MaskRay wrote:
> Indent, i.e. `CASE2-SAME:            1`
I know I suggested this behaviour previously, but I realise that there is a slight flaw in it, as it will also match "Info: 1234" or "Info: 2211" for example. I think you need ^$ regex markers too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74756/new/

https://reviews.llvm.org/D74756





More information about the llvm-commits mailing list