[PATCH] D74544: [MLIR] Add naive fusion of parallel loops.

[Stephan Herhut via Phabricator via llvm-commits]

herhut added inline comments.


================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopFusion.cpp:57
+/// secondPloop reads.
+static bool haveNoWriteReadsToSameElems(
+    ParallelOp firstPloop, ParallelOp secondPloop,
----------------
Maybe `haveNoReadsAfterWriteExceptSameIndex'?


================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopFusion.cpp:100
+/// in secondPloop.
+static bool haveNoReadWritesToSameBufs(ParallelOp firstPloop,
+                                       ParallelOp secondPloop) {
----------------
Would it not suffice to call `haveNoReadAfterWritesExpectSameIndex` with arguments reversed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74544/new/

https://reviews.llvm.org/D74544