[PATCH] D74819: [DebugInfo] Report unsupported maximum_operations_per_instruction values

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ikudrin, dblaikie, probinson, JDevlieghere, aprantl, MaskRay.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

This patch adds a check which reports an unsupported value of the maximum_operations_per_instruction field in a debug line table header. This is reported once per line table, at most, and only if the table would otherwise need to use it (i.e. never for tables with version 3 or less, or for tables which don't use DW_LNS_const_add_pc or special opcodes). Unsupported values are currently any apart from 1.

See also D43470 <https://reviews.llvm.org/D43470>, which takes a similar approach for bad line_range values (i.e. 0). I may refactor the pair of them to avoid the code duplication.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74819

Files:
  llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74819.245348.patch
Type: text/x-patch
Size: 12432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200219/a258636a/attachment.bin>