[PATCH] D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp.

[Alexander Belyaev via Phabricator via llvm-commits]

pifon2a marked an inline comment as done.
pifon2a added inline comments.


================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:188
+              "ValueRange lowerBounds, ValueRange upperBounds, "
+              "ValueRange steps, ArrayRef<Type> resultTypes">
   ];
----------------
mehdi_amini wrote:
> Isn't a loop always supposed to capture as operands the same types as the returned values? If so then why do we have a builder with `resultTypes`? I'd expect these to be inferred from the captured operands?
> 
> It is a problem with the current reduce, which does not model this, but that's a bug to fix right? And so adding a builder around the incorrect design does not seem right to me.
Ploops don't really capture any operands from which we can infer result types. The result types correspond to the ReduceOps in the body of the ploop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74708/new/

https://reviews.llvm.org/D74708