[PATCH] D74611: [obj2yaml][WIP] - Fix indentations in the ELF output.

[George Rimar via Phabricator via llvm-commits]

grimar marked 2 inline comments as done.
grimar added a comment.

In D74611#1881673 <https://reviews.llvm.org/D74611#1881673>, @MaskRay wrote:

> Does this patch handle sequence types with `has_FlowTraits` (`llvm/Support/YAMLTraits.h`) set? It is used for auto line wrapping.
>
>   Key: [value0, value1, value2,
>         value3, value4,
>         value5]
>
>
>


Not yet. Yesterday I've found this and other cases where the current code doesn't produce an expected result.
Though it looks like they can be fixed without adding much complexity to the algorithm, but I had no chance to check yet.

> I don't know whether obj2yaml has such objects to emit, though.
> 
> Maybe you can summarize the problems and ask on llvm-dev?
> 
> (I think the direction of D73045 <https://reviews.llvm.org/D73045> may be fine.)

I do not like the direction of D73045 <https://reviews.llvm.org/D73045>. It looks to me too intrusive for a "add or remove few spaces" task.
(Note that the version posted in D73045 <https://reviews.llvm.org/D73045> does not solve the problem, it should be extended and it seeems
to me that it should be noticably larger to solve the task).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74611/new/

https://reviews.llvm.org/D74611