[PATCH] D74228: [PatternMatch] Match XOR variant of unsigned-add overflow check.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 19 00:31:25 PST 2020


nikic accepted this revision.
nikic added a comment.

LG to me as well.



================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1230
+    assert(BO->hasOneUse() &&
+           "Patterns with XOr should use the BO only in the compare");
   Value *OV = Builder.CreateExtractValue(MathOV, 1, "ov");
----------------
nit: xor or XOR


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74228/new/

https://reviews.llvm.org/D74228





More information about the llvm-commits mailing list