[PATCH] D74809: Include static prof data when collecting loop BBs
Bill Wendling via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 21:11:53 PST 2020
void marked 2 inline comments as done.
void added inline comments.
================
Comment at: llvm/test/CodeGen/X86/ragreedy-bug.ll:35
; CHECK-NEXT: movzbl
-; CHECK-NEXT: testl
-; CHECK-NEXT: jne
+; CHECK-NEXT: jmp
----------------
nickdesaulniers wrote:
> this change is curious; I'd have expected `je`'s to flip to `jne`'s or vice versa, but not unconditional jumps.
This change is very interesting actually. The two mem-move blocks are placed at the end of the function. They then branch back up into what was a tail duplicated block. So the testl/je statements are actually at the original place, and the jmp here is just a simple branch to them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74809/new/
https://reviews.llvm.org/D74809
More information about the llvm-commits
mailing list