[PATCH] D74764: [yaml2obj][WIP] - Automatically assign VA for allocatable sections.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 17:27:08 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-address-assign.yaml:54
+    Size:  0x1
+## Show we can return back in the address space and
+## continue placing sections. The order of sections in the
----------------
Add a ShSize test somewhere.


================
Comment at: llvm/test/tools/yaml2obj/ELF/section-address-assign.yaml:64
+    Type:    SHT_PROGBITS
+    Flags:   [ SHF_ALLOC ]
+## Used to trigger creation of .dynsym and .dynstr.
----------------
Add a non-SHF_ALLOC section (e.g. .rela.debug_info) to test this rule applies on non-SHF_ALLOC sections.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74764/new/

https://reviews.llvm.org/D74764





More information about the llvm-commits mailing list