[PATCH] D74647: [mlir][ODS] Add a new trait `TypesMatchWith`

[River Riddle via Phabricator via llvm-commits]

rriddle marked an inline comment as done.
rriddle added inline comments.


================
Comment at: mlir/include/mlir/Dialect/StandardOps/Ops.td:1071-1073
+  let arguments = (ins BoolLike:$condition, IntegerOrFloatLike:$true_value,
+                       IntegerOrFloatLike:$false_value);
+  let results = (outs IntegerOrFloatLike:$result);
----------------
stephenneuendorffer wrote:
> rriddle wrote:
> > stephenneuendorffer wrote:
> > > Unrelated change?  Why does this need to be IntegerOrFloatLike?
> > Not unrelated, getI1SameShape asserts that the given type is integer-or-float like. This avoids that assert.
> It seems like this is an unnecessary condition for 'select' which used to be type generic...
It was never truly type generic, it was just never verified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74647/new/

https://reviews.llvm.org/D74647