[PATCH] D74647: [mlir][ODS] Add a new trait `TypesMatchWith`
Lei Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 15:47:46 PST 2020
antiagainst accepted this revision.
antiagainst added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp:1107
+ const char *code = R"(
+ auto sizeAttr = getAttrOfType<DenseIntElementsAttr>("{0}");
----------------
Give it a more descriptive name like `checkAttrSizedValueSegmentsCode` or something? (Sorry my bad previously using just `code`. :))
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74647/new/
https://reviews.llvm.org/D74647
More information about the llvm-commits
mailing list