[PATCH] D74642: [CodeGenPrepare] Speed up placeDbgValues, NFC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:34:26 PST 2020


rnk added a comment.

I think for the case of reordering two existing instructions, the ordering will be invalidated. So, after D51664 <https://reviews.llvm.org/D51664>, this is still O(n^2) in the case where every other instruction is a dbg.value that needs sinking. However, that's a pretty pathological input, and I think we could address that use case in a general way by leaving holes in the numbering, rather than by keeping this patch around.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74642/new/

https://reviews.llvm.org/D74642





More information about the llvm-commits mailing list