[PATCH] D74651: [WIP] Add intrinsics and operand bundles for inalloca replacement llvm.call.setup

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:11:40 PST 2020


aeubanks added inline comments.


================
Comment at: llvm/lib/IR/Verifier.cpp:3061-3062
+             Call);
+    } else {
+      Assert(false, "unknown bundle");
     }
----------------
rnk wrote:
> The verifier shouldn't reject unknown bundles, the idea is to allow other bundles as an extension point.
Done.
I had (and still have) no idea how "callsetup" was getting read as a LLVMContext::OB_callsetup so I wanted to make sure that this branch was actually taken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651





More information about the llvm-commits mailing list