[PATCH] D74632: [AArch64][SVE] Add initial backend support for FP splat_vector

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 15:02:35 PST 2020


cameron.mcinally updated this revision to Diff 245282.
cameron.mcinally added a comment.

Don't mark f16 as a legal ConstantFP for SVE.

> That said, I think making `+sve` imply `+fullfp16` solves the immediate problem you're running into, where constantfp 0.0 is getting lowered to a constant pool.

I don't have a lot of intuition built up around fp16, so I'm hesitant to change it. I will open another Diff linking the two feature flags though, so we can start a discussion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74632/new/

https://reviews.llvm.org/D74632

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
  llvm/lib/Target/AArch64/AArch64InstrFormats.td
  llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
  llvm/test/CodeGen/AArch64/sve-vector-splat.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74632.245282.patch
Type: text/x-patch
Size: 7996 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200218/e757982f/attachment.bin>


More information about the llvm-commits mailing list