[PATCH] D67133: [GlobalISel]: Fix some non determinism exposed in CSE due to not notifying observers about mutations + add verification for CSE

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 14:44:04 PST 2020


aditya_nandakumar updated this revision to Diff 245272.
aditya_nandakumar added a comment.

Updated based on feedback.
CSEInfo::verify now returns Error which we can assert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67133/new/

https://reviews.llvm.org/D67133

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CSEInfo.h
  llvm/include/llvm/CodeGen/GlobalISel/GISelChangeObserver.h
  llvm/include/llvm/CodeGen/MachineFunction.h
  llvm/lib/CodeGen/GlobalISel/CSEInfo.cpp
  llvm/lib/CodeGen/GlobalISel/GISelChangeObserver.cpp
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
  llvm/lib/CodeGen/GlobalISel/Legalizer.cpp
  llvm/lib/CodeGen/GlobalISel/Utils.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67133.245272.patch
Type: text/x-patch
Size: 8663 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200218/cf77f122/attachment.bin>


More information about the llvm-commits mailing list