[PATCH] D74682: [mlir][DeclarativeParser] Add an 'attr-dict-with-keyword' directive
Jacques Pienaar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 14:44:05 PST 2020
jpienaar added inline comments.
================
Comment at: mlir/docs/OpDefinitions.md:593
+ - Represents the attribute dictionary of the operation, but prefixes the
+ dictionary with an `attributes` keyword.
----------------
I'm not sure I follow this, so `attributes` is just some string? Why do we need to treat attributes special vs just have "`attributes` attr-dic" ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74682/new/
https://reviews.llvm.org/D74682
More information about the llvm-commits
mailing list