[PATCH] D74632: [AArch64][SVE] Add initial backend support for FP splat_vector

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 13:12:23 PST 2020


efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:878
+
+    setOperationAction(ISD::ConstantFP, MVT::f16, Legal);
+
----------------
I think `setOperationAction(ISD::ConstantFP, MVT::f16, Legal)` is going to cause a fatal error for some FP constants. Not that they would be impossible to lower appropriately, but I don't think we have the necessary patterns.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74632/new/

https://reviews.llvm.org/D74632





More information about the llvm-commits mailing list