[PATCH] D74165: [x86] [DAGCombine] Prefer shifts of constant widths.
Justin Lebar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 13:03:18 PST 2020
jlebar added a comment.
Thank you for the comments!
> Have you found any other targets that would benefit from this? Otherwise we might consider put it inside X86ISelLowering initially?
Good question. @arsenm says on Discord he'd want this on AMDGPU for 64-bit shifts:
> It's indirectly better for AMDGPU since if it's a 64-bit shift we can reduce it to 32-bit shifts
> i.e. https://reviews.llvm.org/rG85508595350e2de0218c15f1c0088cd9f6236894
> I would probably want that on, maybe not at -Oz
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74165/new/
https://reviews.llvm.org/D74165
More information about the llvm-commits
mailing list