[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 12:26:42 PST 2020


sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/docs/LangRef.rst:913
 
-Note that the Mach-O platform doesn't support COMDATs, and ELF and WebAssembly
-only support ``any`` as a selection kind.
+Note that XCOFF and the Mach-O platform don't support COMDATs, and ELF and
+WebAssembly only support ``any`` as a selection kind.
----------------
really minor nit: The current wording sounds a bit odd to my ear. Maybe either `XCOFF and Mach-O platforms` or  `XCOFF and Mach-O don't support COMDATs, ...` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74631/new/

https://reviews.llvm.org/D74631





More information about the llvm-commits mailing list