[PATCH] D74747: [JumpThreading] Skip unconditional PredBB when threading jumps through two basic blocks

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 11:02:57 PST 2020


kazu accepted this revision.
kazu added a comment.

LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/JumpThreading.cpp:2116
 
   // Require that PredBB end with a Branch.  If PredBB ends with an
   // unconditional branch, we should be merging PredBB and BB instead.  For
----------------
Could you say "conditional Branch" instead of "Branch"?  Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74747/new/

https://reviews.llvm.org/D74747





More information about the llvm-commits mailing list