[PATCH] D74750: [X86] Rewrite LowerBRCOND to remove dead code and handle ISD::SETCC and overflow ops directly.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 09:49:10 PST 2020


craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:23142
+           Opc == ISD::USUBO || Opc == ISD::SMULO || Opc == ISD::UMULO));
 }
 
----------------
RKSimon wrote:
> Maybe put this in ISDOpcodes.h ?
The dependency on SDValue probably means it needs to go in SelectionDAGNodes.h?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74750/new/

https://reviews.llvm.org/D74750





More information about the llvm-commits mailing list