[PATCH] D74747: [JumpThreading] Handle unconditional PredBB when threading jumps through two basic blocks
Kazu Hirata via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 09:02:58 PST 2020
kazu accepted this revision.
kazu added a comment.
This revision is now accepted and ready to land.
Thank you for catching this! I meant to handle PredBB ending with a conditional branch only, but I wasn't aware that PredBB could end with an unconditional branch if its address is taken.
================
Comment at: llvm/test/Transforms/JumpThreading/thread-two-bbs6.ll:8
+
+define dso_local i32 @f(i32* %0) {
+; CHECK-LABEL: @f
----------------
Nit: May I suggest to remove dso_local if it's not critical to the test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74747/new/
https://reviews.llvm.org/D74747
More information about the llvm-commits
mailing list