[PATCH] D74604: [LLD][ELF][ARM] Fix support for SBREL type relocations

[Peter Smith via Phabricator via llvm-commits]

peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Thanks for the update. Apart from the extra / needed in some of the comment strings this looks good to me. Happy for you to add those prior to commit.



================
Comment at: lld/test/ELF/arm-mov-relocs.s:9
 
-// Test the R_ARM_MOVW_ABS_NC and R_ARM_MOVT_ABS relocations as well as
-// the R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS relocations.
+// Test the following relocation pairs:
+//  * R_ARM_MOVW_ABS_NC and R_ARM_MOVT_ABS
----------------
The comment doesn't involve lit commands so these should start with /// for example:
```
///  * R_ARM_MOVW_ABS_NC and R_ARM_MOVT_ABS
///  * R_ARM_MOVW_PREL_NC and R_ARM_MOVT_PREL
///  * R_ARM_MOVW_BREL_NC and R_ARM_MOVT_BREL
///
///  * R_ARM_THM_MOVW_BREL_NC and R_ARM_THM_MOVT_BREL
```


================
Comment at: lld/test/ELF/arm-mov-relocs.s:49
+// CHECK:        movt    r3, #2
+// :upper16:label3 + 4 = :upper16:0x30000 = 3
+// CHECK:        movt    r4, #3
----------------
This type of explanatory comment would need the extra /
/// :upper16:label3 + 4 = :upper16:0x30000 = 3


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74604/new/

https://reviews.llvm.org/D74604