[PATCH] D74691: [Attributor] add some pattern to containsCycle

[omar ahmed via Phabricator via llvm-commits]

omarahmed added a comment.

Thanks for this great reviews :)

> They're equal: This SCC is a loop, continue to the next.
>  The loop is bigger: The SCC is not a loop, return.

@baziotis Shouldn't this conditions be reversed as when we find a loop we should check the max trip count and return if it was 0 , and when the loop is bigger we should continue looping on the SCCs ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691