[PATCH] D73201: [FPEnv][AArch64] Add lowering and instruction selection for STRICT_FP_ROUND

Tue Feb 18 05:54:58 PST 2020

john.brawn added a comment.

In D73201#1878706 <https://reviews.llvm.org/D73201#1878706>, @hans wrote:

> A user reported running into asserts when compiling musl for aarch64 with -frounding-math.
>  It appears to be fixed (well, at least it doesn't assert..) by this patch. Should it be cherry-picked to the 10.x branch?

There's a bunch of strict-math-related commits that are present on trunk that aren't present on 10.x and which should be cherry-picked. The complete list is, I think:

594a89f7270d <https://reviews.llvm.org/rG594a89f7270da74c89f2321432bc6a7135773fa5> [FPEnv][ARM] Don't call mutateStrictFPToFP when lowering
8bc790f9e6a6 <https://reviews.llvm.org/rG8bc790f9e6a6fc6d8fe8f41a7120269366fa0957> [AArch64][FPenv] Update chain of int to fp conversion
0ec57972967d <https://reviews.llvm.org/rG0ec57972967dfb43fc022c2e3788be041d1db730> [ARM] Fix infinite loop when lowering STRICT_FP_EXTEND
68cf574857c8 <https://reviews.llvm.org/rG68cf574857c81f711f498a479855a17e7bea40f7> [FPEnv][AArch64] Add lowering of f128 STRICT_FSETCC
b37d59353f69 <https://reviews.llvm.org/rGb37d59353f699e99f139a9227a6a69964ef4b132> [FPEnv][ARM] Add lowering of STRICT_FSETCC and STRICT_FSETCCS
0bb9a27c9895 <https://reviews.llvm.org/rG0bb9a27c9895c0fbc3f55f56ad7f1e1927398fce> [FPEnv][AArch64] Add lowering and instruction selection for strict conversions
258d8dd76afd <https://reviews.llvm.org/rG258d8dd76afd88a12539b182a53ff21dcba16a2d> [FPEnv][AArch64] Add lowering and instruction selection for STRICT_FP_ROUND
2224407ef5ba <https://reviews.llvm.org/rG2224407ef5baf6100fa22420feb4d25af1a9493f> Add lowering of STRICT_FSETCC and STRICT_FSETCCS

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73201/new/

https://reviews.llvm.org/D73201