[PATCH] D74761: [DebugInfo] Remove a misleading comment for llvm::dwarf::FDE.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 05:50:03 PST 2020


ikudrin created this revision.
ikudrin added reviewers: jhenderson, dblaikie, probinson, aprantl, rafauler, eliben.
ikudrin added projects: LLVM, debug-info.

The comment described a linked CIE to be acquired lazily. That is not true and looks like it was never true.

Notes. The comment was initially added in https://reviews.llvm.org/rGfd08bc195b36b2262f9ee4b283eef44b0520ebed and was moved into its current location in https://reviews.llvm.org/D43313.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D74761

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h


Index: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
===================================================================
--- llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
+++ llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h
@@ -223,9 +223,6 @@
 /// DWARF Frame Description Entry (FDE)
 class FDE : public FrameEntry {
 public:
-  // Each FDE has a CIE it's "linked to". Our FDE contains is constructed with
-  // an offset to the CIE (provided by parsing the FDE header). The CIE itself
-  // is obtained lazily once it's actually required.
   FDE(uint64_t Offset, uint64_t Length, int64_t LinkedCIEOffset,
       uint64_t InitialLocation, uint64_t AddressRange, CIE *Cie,
       Optional<uint64_t> LSDAAddress, Triple::ArchType Arch)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74761.245136.patch
Type: text/x-patch
Size: 750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200218/a9630ee7/attachment.bin>


More information about the llvm-commits mailing list