[PATCH] D74754: [IR] Set name when inserting 'llvm::Value*'
Brian Gesiak via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 05:22:58 PST 2020
modocache updated this revision to Diff 245132.
modocache marked an inline comment as done.
modocache added a comment.
Thanks for the reviews! Good point about the variable casing, I changed it and am going to commit this shortly.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74754/new/
https://reviews.llvm.org/D74754
Files:
llvm/include/llvm/IR/IRBuilder.h
llvm/unittests/IR/IRBuilderTest.cpp
Index: llvm/unittests/IR/IRBuilderTest.cpp
===================================================================
--- llvm/unittests/IR/IRBuilderTest.cpp
+++ llvm/unittests/IR/IRBuilderTest.cpp
@@ -929,4 +929,11 @@
EXPECT_EQ(MN2, MF2->getRawElements());
EXPECT_TRUE(verifyModule(*M));
}
+
+TEST_F(IRBuilderTest, NoFolderNames) {
+ IRBuilder<NoFolder> Builder(BB);
+ auto *Add =
+ Builder.CreateAdd(Builder.getInt32(1), Builder.getInt32(2), "add");
+ EXPECT_EQ(Add->getName(), "add");
+}
}
Index: llvm/include/llvm/IR/IRBuilder.h
===================================================================
--- llvm/include/llvm/IR/IRBuilder.h
+++ llvm/include/llvm/IR/IRBuilder.h
@@ -134,9 +134,9 @@
return C;
}
- Value *Insert(Value *V, const Twine& = "") const {
+ Value *Insert(Value *V, const Twine &Name = "") const {
if (Instruction *I = dyn_cast<Instruction>(V))
- return Insert(I);
+ return Insert(I, Name);
assert(isa<Constant>(V));
return V;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74754.245132.patch
Type: text/x-patch
Size: 998 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200218/389336d9/attachment.bin>
More information about the llvm-commits
mailing list