[PATCH] D73801: [LoopFission]: Loop Fission Interference Graph (FIG)

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I think it would be great if the patch that uses the infrastructure added here would also be available for review, to get a better idea how it is actually used. It also makes testing much easier.

> I choose to name the pass Loop Fission to avoid confusion with the existing LoopDistribution pass (eventually Loop Fission should replace that pass). Also Loop Fission is the opposite of Loop Fusion :-) ?

I think adding this as separate pass with a slightly different name also causes a bunch of confusion and potentially split the development effort, in case people improve the existing LoopDistribute. Is there a reason for adding a completely new pass, rather than working on improving/replacing the existing LoopDistribute? I am a bit worried that in the end we end up with 2 passes that are not used/enabled.  Would it not be possible/easier to add an option to use the FIG for partition in LoopDistribute and incrementally improve LoopDistribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73801/new/

https://reviews.llvm.org/D73801