[PATCH] D74225: [AIX] Implement formal arguments passed in stack memory

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 03:26:25 PST 2020


ZarkoCA marked 5 inline comments as done.
ZarkoCA added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7007
+      // Get the actual size of the argument type.
+      const unsigned ObjSize = VA.getValVT().getStoreSize();
+      assert(ObjSize <= ArgSize);
----------------
cebowleratibm wrote:
> I find the use of name "ObjSize" and "ArgSize" confusing.  Suggest sticking to terminology "ValueSize" and "LocSize".
Thanks, I agree it's better calling them something else. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74225/new/

https://reviews.llvm.org/D74225





More information about the llvm-commits mailing list