[PATCH] D74604: [LLD][ARM] Fix support for SBREL type relocations
Tamas Petz via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 18 00:33:54 PST 2020
tamas.petz added inline comments.
================
Comment at: lld/test/ELF/arm-mov-relocs.s:23
.section .R_ARM_MOVW_ABS_NC, "ax",%progbits
+ .align 8
movw r0, :lower16:label
----------------
MaskRay wrote:
> Is the overalignment (8) significant?
Technically it is not.
It is only for readability, the different sections have their start addresses increasing by 0x100.
When I tried to follow the existing pattern where all addresses are written I found this to be useful.
It was easier to add new tests as it will happen in an upcoming patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74604/new/
https://reviews.llvm.org/D74604
More information about the llvm-commits
mailing list