[PATCH] D74754: [IR] Set name when inserting 'llvm::Value*'

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 18 00:25:01 PST 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Looks like a straight-forward fix, thanks! LGTM. Please wait a bit until committing, in case there are additional comments.



================
Comment at: llvm/unittests/IR/IRBuilderTest.cpp:934
+TEST_F(IRBuilderTest, NoFolderNames) {
+  IRBuilder<NoFolder> builder(BB);
+  auto *add =
----------------
Nit: variables should start with upper case? (https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74754/new/

https://reviews.llvm.org/D74754





More information about the llvm-commits mailing list