[PATCH] D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff marked 7 inline comments as done.
sepavloff added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:25774
+  int OldCWFrameIdx =
+      MF.getFrameInfo().CreateStackObject(4, StackAlignment.value(), false);
+  SDValue StackSlot =
----------------
craig.topper wrote:
> I have no idea why FLT_ROUNDS calls TFI.getStackAlignment() to get the second parameter here. It should just be 4.
Changed here but implementation of `LowerFLT_ROUNDS_` was not changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74730/new/

https://reviews.llvm.org/D74730