[PATCH] D74023: [RISCV] ELF attribute section for RISC-V

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/Support/ELFAttributeParser.h:31
+
+  uint64_t ParseInteger(const uint8_t *Data, uint32_t &Offset);
+  StringRef ParseString(const uint8_t *Data, uint32_t &Offset);
----------------
Use `camelCase` function names.

You can even start to use `variableName` for variables. Because this patch adds many new files. They don't need to get stuck with existing `VariableName` rule which is considered broken  https://lists.llvm.org/pipermail/llvm-dev/2019-February/129907.html


================
Comment at: llvm/include/llvm/Support/ELFBuildAttributes.h:22
+
+using TagNameMap = ArrayRef<struct TagNameItem>;
+
----------------
include llvm/ADT/ArrayRef.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74023/new/

https://reviews.llvm.org/D74023