[PATCH] D73998: [DA] renaming the -da-disable-delinearization-checks option

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 12:39:45 PST 2020


Meinersbur added a comment.

As suggestion in D73995 <https://reviews.llvm.org/D73995>, subscripts derived from GEP might be valid with `inrange` modifiers or when we verify that the value range always falls into the dimension's range (e.g. with `ScalarEvolution::getRangeRef`).

I am not convinced the new name is better because "assume inrange subscripts" reads to me like the subscripts are unambiguous (e.g. from the source code) can be reasoned about, while they are derived heuristically, at least in the delinerization case. Alternative suggestions: "-da-allow-unsafe-derived(-multidimensional)-subscripts", "-da-disable-derived(-multidimensional)-index-range-checks", "-da-assume-nonoverlapping-of-heuristically-derived-multidimensional-array-structures" (or combinations thereof).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73998/new/

https://reviews.llvm.org/D73998





More information about the llvm-commits mailing list