[PATCH] D74647: [mlir][ODS] Add a new trait `TypesMatchWith`

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar added a comment.

Just brief scan :)



================
Comment at: mlir/include/mlir/IR/OpBase.td:1721
+// A type constraint that denotes that 'lhs' has the same type as 'rhs' when the
+// given 'transformer' is applied.
+class TypesMatchWith<string description, string lhsArg, string rhsArg,
----------------
Could we do something like:

that denotes that `transformer(lhs) == rhs` ?

(makes it clear where transformer is applied, simpler to read :))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74647/new/

https://reviews.llvm.org/D74647