[PATCH] D72885: Add Query API for llvm.assume holding attributes

[Tyker via Phabricator via llvm-commits]

Tyker added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/KnowledgeRetention.cpp:88
+            ? StringRef("")
+            : (*(Op.input_begin() + BOIE_WasOn))->getName());
   };
----------------
jdoerfert wrote:
> This still uses the value name in the key, right? Does this work if the values are renamed arbitrarily?
The Name is still used in the key. but this is only to get a full ordering without depending on pointer values or other sources of non-determinism. the lookup algorithm doesn't depend on Names.

if there is an other deterministic source that can be used for ordering that you would feel more comfortable with, it can be used instead.

for example the current unit test passes when we use the reverse of the name. also unit test have a test with replaceAllUsesWith.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72885/new/

https://reviews.llvm.org/D72885