[PATCH] D74446: AMDGPU/GlobalISel: Custom lower 32-bit G_UDIV/G_UREM

[Matt Arsenault via Phabricator via llvm-commits]

arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstructions.td:2150
+  let InOperandList = (ins type1:$src);
+  let hasSideEffects = 0;
+}
----------------
rampitec wrote:
> What about division by zero? Isn't it a side effect?
Just as with sdiv/udiv, this isn't considered a side effect. I think the trap only does anything if we enable exceptions, which we don't


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74446/new/

https://reviews.llvm.org/D74446