[PATCH] D74707: [mlir] NFC: Rename LLVMOpLowering::lowering to LLVMOpLowering::typeConverter

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 09:54:09 PST 2020


rriddle accepted this revision.
rriddle added a comment.

Awesome!



================
Comment at: mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h:374
 protected:
   // Back-reference to the lowering class, used to call type and function
   // conversions accounting for potential extensions.
----------------
Can we change this to /// now? Also the comment is a bit out of date.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74707/new/

https://reviews.llvm.org/D74707





More information about the llvm-commits mailing list