[PATCH] D74711: AMDGPU/GlobalISel: Allow arbitrary global values

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 09:54:08 PST 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.h:266
 
+  static bool isNonGlobalAddrSpace(unsigned AS) {
+    return AS == AMDGPUAS::LOCAL_ADDRESS || AS == AMDGPUAS::REGION_ADDRESS;
----------------
The function name is misleading, private is also non-global.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74711/new/

https://reviews.llvm.org/D74711





More information about the llvm-commits mailing list