[PATCH] D74708: [MLIR][Ploops] Add custom builders from ParallelOp and ReduceOp.

[Stephan Herhut via Phabricator via llvm-commits]

herhut requested changes to this revision.
herhut added a comment.
This revision now requires changes to proceed.

Thanks for adding the builders!



================
Comment at: mlir/include/mlir/Dialect/LoopOps/LoopOps.td:240
+    OpBuilder<"Builder *builder, OperationState &result, "
+              "Value initValue">
+  ];
----------------
Why is this called `initValue`? It is the value to be reduced.


================
Comment at: mlir/lib/Dialect/LoopOps/LoopOps.cpp:239
 
+void ParallelOp::build(Builder *builder, OperationState &result, ValueRange lbs,
+                       ValueRange ubs, ValueRange steps,
----------------
Can you express the above builder by calling this builder? Or have the `resultTypes` have an empty default?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74708/new/

https://reviews.llvm.org/D74708