[PATCH] D74320: GlobalISel: Add combine to narrow G_LSHR

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 06:25:06 PST 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1405-1407
+bool CombinerHelper::matchCombineShiftToUnmerge(MachineInstr &MI,
+                                                unsigned TargetShiftSize,
+                                                unsigned &ShiftVal) {
----------------
nhaehnle wrote:
> Please add a comment describing what this matches.
That would be redundant with the one on the declaration?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74320/new/

https://reviews.llvm.org/D74320





More information about the llvm-commits mailing list