[PATCH] D74642: [CodeGenPrepare] Speed up placeDbgValues, NFC

[Jeremy Morse via Phabricator via llvm-commits]

jmorse accepted this revision.
jmorse added a comment.

LGTM landed whichever way; am I right in thinking that this approach will still be faster than the domtree query even if the block is very large? (On account of the pointer set lookup being ordered, instead of walking through each instruction in a block).

Longer term, placeDbgValues should be entirely eliminated anyway, IIRC it's only still around because CodeGenPrepare doesn't try to update variable locations when it optimises things.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74642/new/

https://reviews.llvm.org/D74642