[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect

[shraiysh via Phabricator via llvm-commits]

shraiysh added inline comments.


================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:637
+  for (Value v : values) {
+    assert(valueMapping.find(v) != valueMapping.end() &&
+           "referencing undefined value");
----------------
rriddle wrote:
> nit: llvm::is_contained
I think `llvm::is_contained` is a wrapper for `std::find`. I am not sure if there is a neat way of looking for keys in a map using `std::find` (and hence `llvm::is_contained`). Please let me know if there is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71888/new/

https://reviews.llvm.org/D71888