[PATCH] D71888: [mlir] Added llvm.resume and personality functions in LLVM IR Dialect
shraiysh via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 17 06:07:18 PST 2020
shraiysh added inline comments.
================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:637
+ for (Value v : values) {
+ assert(valueMapping.find(v) != valueMapping.end() &&
+ "referencing undefined value");
----------------
rriddle wrote:
> nit: llvm::is_contained
I think `llvm::is_contained` is a wrapper for `std::find`. I am not sure if there is a neat way of looking for keys in a map using `std::find` (and hence `llvm::is_contained`). Please let me know if there is.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71888/new/
https://reviews.llvm.org/D71888
More information about the llvm-commits
mailing list