[PATCH] D74705: [mlir][quantizer] Support quantizing sparse tensors

Alexey Romanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 05:48:57 PST 2020


alexeyr added a comment.

I've added `ShapedType::withElementType` here because I noticed there is equivalent code in other places as well, but changes to them would be a separate patch. Alternatively, this method could be just defined locally.

On the other hand, as a comment says, `getFlattenedIndex` method duplicates a protected method on `ElementsAttribute`; it could be avoided by moving this one to a static method on `ElementsAttribute` and making the member method call it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74705/new/

https://reviews.llvm.org/D74705





More information about the llvm-commits mailing list