[PATCH] D74060: [KnownBits] Move AND, OR and XOR logic into KnownBits

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 17 05:39:47 PST 2020


nikic added a comment.

Imho this use of operator-overloading is fine. I think it's understood that operations on KnownBits always mean "what are the known bits after performing this operation", not "apply this operation element-wise", so I think there's little potential for confusion here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74060/new/

https://reviews.llvm.org/D74060





More information about the llvm-commits mailing list