[PATCH] D74211: [mlir] use unpacked memref descriptors at function boundaries

Mon Feb 17 02:29:06 PST 2020

ftynse added a comment.

In D74211#1876818 <https://reviews.llvm.org/D74211#1876818>, @dcaballe wrote:

> Thanks for addressing this so quickly and for the feedback! I'm giving it a try. Re reverting patches, this is a very common practice. Sometimes patches are reverted without giving an opportunity to provide a fix. It shouldn't be a problem. LLVM has a no regression policy and testing goes beyond in-tree tests since many vendors have private forks. In any case, I just provided some options so that you could decide. Thanks again for addressing this so quickly!

I know it's common. In this specific situation, you will get in a weird situation where reverting this patch could fix your project, but break other projects, so somebody would revert the revert :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74211/new/

https://reviews.llvm.org/D74211