[PATCH] D74600: [AMDGPU] Don’t marke the .note section as ALLOC

[Sebastian Neubauer via Phabricator via llvm-commits]

Flakebi updated this revision to Diff 244927.
Flakebi added a comment.

Fix test, I hope the existing test suffices.

I thought about adding a test that checks that the code section is the only section with flags != 0
but this won’t hold when a data section or others get used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74600/new/

https://reviews.llvm.org/D74600

Files:
  llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  llvm/test/CodeGen/AMDGPU/hsa.ll


Index: llvm/test/CodeGen/AMDGPU/hsa.ll
===================================================================
--- llvm/test/CodeGen/AMDGPU/hsa.ll
+++ llvm/test/CodeGen/AMDGPU/hsa.ll
@@ -19,8 +19,7 @@
 ; ELF: }
 
 ; ELF: SHT_NOTE
-; ELF: Flags [ (0x2)
-; ELF: SHF_ALLOC (0x2)
+; ELF: Flags [ (0x0)
 ; ELF: ]
 ; ELF: SectionData (
 ; ELF: 0000: 04000000 08000000 01000000 414D4400
Index: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
===================================================================
--- llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
+++ llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
@@ -440,7 +440,7 @@
 
   S.PushSection();
   S.SwitchSection(Context.getELFSection(
-    ElfNote::SectionName, ELF::SHT_NOTE, ELF::SHF_ALLOC));
+    ElfNote::SectionName, ELF::SHT_NOTE, 0));
   S.emitIntValue(NameSZ, 4);                                  // namesz
   S.emitValue(DescSZ, 4);                                     // descz
   S.emitIntValue(NoteType, 4);                                // type


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D74600.244927.patch
Type: text/x-patch
Size: 1049 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200217/4ba3cb80/attachment.bin>